-
Notifications
You must be signed in to change notification settings - Fork 14
pin setup-envtest to fix test breakage #278
Conversation
Signed-off-by: Kim Tsao <ktsao@redhat.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick 1.1.x Cherry-picking this in 1.1.x because PR tests on this branch are failing for the same reason. |
@rm3l: new pull request created: #280 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Current PR tests are failing due to this error:
go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest (in sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240326031119-8afbb50e0eb2): go.mod:3: invalid go version '1.22.0': must match format 1.23
as a result of this change kubernetes-sigs/controller-runtime#2720 (comment)
We need to pin to an older commit in order to work around this.
Which issue(s) does this PR fix or relate to
PR acceptance criteria
rhdh-operator.csv.yaml
file accordinglyHow to test changes / Special notes to the reviewer